Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term class to largo_top_term() output, prevent largo_category_and_tags() from using wrong post in fallback scenario. #1648

Merged
merged 4 commits into from
Mar 15, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Mar 15, 2019

Changes:

  • For largo_category_and_tags does not accept specification of an arbitrary post ID #1647, prevent largo_top_term() from calling largo_category_and_tags() when the post ID passed to largo_top_term() does not match get_the_ID's post ID, because there is presently no way to pass that ID to largo_category_and_tags().
  • For Add identifying class to top term output, to enable term-specific styles #1646, adds taxonomy-slug output as class on largo_top_term() for the top term, and in largo_category_and_tags() to support that output in a fallback case.
  • Fixes problem in the homepage featured stories zone where the post ID was not properly specified to largo_top_term(), and changed to largo_maybe_top_term() while I was in there. This means that largo_top_term() will have the specified post ID in that zone, and in combination with the largo_category_and_tags() change above, if there's no top term set on a post, there'll be no empty h5 element there.

…tags(), and a fix for #1647 by not calling largo_category_and_tags() when the post given to largo_top_term() does not match the post returned by get_the_ID()
@benlk benlk added this to the 0.6.2 milestone Mar 15, 2019
@benlk benlk changed the title Misc. top term improvements Add term class to largo_top_term() output, prevent largo_category_and_tags() from using wrong post in fallback scenario. Mar 15, 2019
@benlk
Copy link
Collaborator Author

benlk commented Mar 15, 2019

To do:

  • update changelog for this
  • tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant